widelands: fix macOS requirements #213405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khipp
approved these changes
May 22, 2025
This was referenced May 23, 2025
This was referenced Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #213329, having
depends_on macos:nested in an on_system block causes the generated API to be inaccurate (see https://formulae.brew.sh/cask/widelands). So, instead of having different macOS dependencies depending on architecture, this has a single minimum OS requirement for the entire cask, and gives different downloads depending on if we're running Sonoma vs. something earlier.The way to handle this kind of bifurcated OS/arch requirements isn't obvious (in this case, where macOS ARM versions of a certain age only have the option of running the Intel version), but it's been done before in
jellyfin-media-player.