Skip to content

Cross-platform java detection #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Conversation

maxim-belkin
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Adapting java detection code to work on Linux.
Moved current implementation to extend/os/mac/system_config.rb.
New default is based on java -version and works on both platforms.

CC @sjackman

@sjackman
Copy link
Contributor

Thanks, Maxim!

javas << item.text
end
javas.uniq.join(", ")
java_version[/java version "([0-9\._]+)"/, 1] || "N/A"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0-9 can be \d

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@MikeMcQuaid MikeMcQuaid merged commit 16df750 into Homebrew:master Feb 23, 2018
@MikeMcQuaid
Copy link
Member

Thanks again @maxim-belkin!

@sjackman
Copy link
Contributor

Thanks for merging, Mike!

@maxim-belkin maxim-belkin deleted the brew-unix-3 branch March 12, 2018 18:49
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants