Skip to content

formula_installer: also run audit_installed for keg_only formulae #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Feb 14, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

check_linkage wasn't warning about broken keg_only bottles because none of the audit_installed checks have been running for keg_only formulae. These checks have always been disabled for keg_only formulae, ever since keg_only formulae were first introduced in ee2b521 as checks kept getting added to the non-keg_only section of that block. But I cannot see any current reason they shouldn't be run. For keg_only formulae, we should still skip the checks for whether HOMEBREW_PREFIX/bin and HOMEBREW_PREFIX/sbin are in your PATH.

@ilovezfs ilovezfs force-pushed the more-checks-for-keg_only branch from 95b90fe to 88b1e92 Compare February 14, 2018 12:55
@ilovezfs ilovezfs merged commit 5e4accb into Homebrew:master Feb 14, 2018
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants