Skip to content

diagnostic: remove cache size check #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Feb 13, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

There's nothing wrong with a cache over 2GB and brew cleanup is not guaranteed to bring the cache size under that threshold. We should not issue doctor warnings that are unfixable by the prescribed advice, especially when the supposed problem isn't actually a problem.

Fixes #3798.
Reverts #3783.

@MikeMcQuaid MikeMcQuaid merged commit 62f1bb7 into Homebrew:master Feb 13, 2018
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew doctor advises cleanup which doesn't help
2 participants