Skip to content

test/utils/svn: Requires svn to succeed #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2018
Merged

test/utils/svn: Requires svn to succeed #3768

merged 1 commit into from
Feb 16, 2018

Conversation

sjackman
Copy link
Contributor

@sjackman sjackman commented Feb 6, 2018 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This test fails on Linux if svn is not installed. I've added :needs_macos. Is there a better way to skip this test when svn is not available?

@sjackman sjackman changed the title utils/svn: Requires svn to succeed test/utils/svn: Requires svn to succeed Feb 6, 2018
@MikeMcQuaid
Copy link
Member

Could do a needs_svn. I think something similar would be preferable as svn is present on our Travis CI builders.

@MikeMcQuaid
Copy link
Member

@sjackman ping?

@sjackman
Copy link
Contributor Author

Done. Sorry for the delay.

@MikeMcQuaid MikeMcQuaid merged commit 7f6e772 into Homebrew:master Feb 16, 2018
@MikeMcQuaid
Copy link
Member

Thanks @sjackman!

@sjackman sjackman deleted the test-svn branch February 16, 2018 15:47
@sjackman
Copy link
Contributor Author

Thanks for merging, Mike!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjackman @MikeMcQuaid