Skip to content

Let Cask doctor exit with 1 via an exception #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Let Cask doctor exit with 1 via an exception #3418

wants to merge 2 commits into from

Conversation

amyspark
Copy link
Contributor

@amyspark amyspark commented Nov 3, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This pull request fixes Homebrew/homebrew-cask#40198 by raising a CaskError if one or more of the checks fails.

Please review!

@ilovezfs ilovezfs added the cask Homebrew Cask label Nov 25, 2017
@amyspark
Copy link
Contributor Author

Bump! In the meanwhile, I rebased this pull req on the latest master commit.

@reitermarkus
Copy link
Member

I think it would be nice to re-use Checkable for this.

@amyspark
Copy link
Contributor Author

amyspark commented Dec 1, 2017

@MikeMcQuaid Thanks for the comment. I'll also take the time to reformat the command a bit, in the spirit of brew cask audit.

@amyspark
Refactor Cask's doctor command
691caf4 
- Remove :failed
- Use Checkable to store the status and warnings/errors
- Refactor the methods using audit as basis
@stale
Copy link

stale bot commented Dec 23, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Dec 23, 2017
@stale stale bot closed this Dec 30, 2017
@amyspark amyspark mentioned this pull request Jan 5, 2018
Merged
5 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cask Homebrew Cask stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug report: brew cask doctor should have return code != 0 in case of error
3 participants
@amyspark @reitermarkus @ilovezfs