rustc_wrapper: pass HOMEBREW_RUSTFLAGS last
#20424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we pass it first, it can be overridden by other arguments passed on the command line. We don't want that. See discussion at Homebrew/homebrew-core#232566.
|
Please provide a better issue/pull request title and/or description! |
ZhongRuoyu
approved these changes
Aug 11, 2025
MikeMcQuaid
approved these changes
Aug 11, 2025
carlocab
added a commit
that referenced
this pull request
Aug 12, 2025
In #20424, we moved `HOMEBREW_RUSTFLAGS` to the end of the compiler invocation, but didn't update the comment. Let's fix that. While we're here, let's fix a `shellcheck disable`.
7 tasks
carlocab
added a commit
that referenced
this pull request
Aug 12, 2025
In #20424, we moved `HOMEBREW_RUSTFLAGS` to the end of the compiler invocation, but didn't update the comment. Let's fix that. While we're here, let's fix these `shellcheck disable`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?If we pass it first, it can be overridden by other arguments passed on
the command line. We don't want that.
See discussion at Homebrew/homebrew-core#232566.
As mentioned in the link above, I don't have time to continue work on this until tomorrow. Feel free to push fixes here as needed if we need this fix to go in ASAP.