Skip to content

brew upgrade --help missing HOMEBREW_UPGRADE_GREEDY #20333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

brew upgrade --help missing HOMEBREW_UPGRADE_GREEDY #20333

merged 1 commit into from
Jul 30, 2025

Conversation

agowa
Copy link
Contributor

@agowa agowa commented Jul 30, 2025 •
edited
Loading

brew upgrade --help currently doesn't mention the existence of HOMEBREW_UPGRADE_GREEDY like e.g. brew outdated --help does.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@p-linnane
Copy link
Member

Makes sense, and thanks. Just run brew style --fix to resolve the style issues.

@agowa
fix: Add missing env var mention on upgrade help page
a7da303 
Add missing env defaults note for `--greedy` to `brew upgrade --help` output
@agowa
Copy link
Contributor Author

agowa commented Jul 30, 2025

done

p-linnane
p-linnane approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution @agowa!

@p-linnane p-linnane enabled auto-merge July 30, 2025 21:39
@p-linnane p-linnane added this pull request to the merge queue Jul 30, 2025
Merged via the queue into Homebrew:main with commit 0162cde Jul 30, 2025
36 checks passed
@agowa agowa deleted the patch-1 branch July 30, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agowa @p-linnane