cmd/info: don't print empty caveats. #20330
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic was insufficient so let's check the actual string.
carlocab
reviewed
Jul 29, 2025
There was a problem hiding this comment.
Not sure this is the right approach, since brew install prints caveats: #20326 (comment)
The right solution is probably to make sure the same caveats that are printed during brew install are also printed by brew info.
@carlocab It's not because the output caveats are not the same. We intentionally don't repeatedly notify about ZSH completions being installed at install time. Unless this doesn't fix the issue for your local reproduction (it does for me) or introduces a regression (please detail it), please ✅ this. |
Rylan12
approved these changes
Jul 29, 2025
|
Sorry, missed this. Thanks! And thanks, @Rylan12! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic was insufficient so let's check the actual string.
Fixes #20326