Skip to content

Enable strict typing in Cask::Audit #20325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

Enable strict typing in Cask::Audit #20325

merged 1 commit into from
Jul 30, 2025

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Jul 29, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I found this helpful to do while I was in the vicinity

@dduugg dduugg force-pushed the dug/typed-cask-audit branch 2 times, most recently from 41a715e to 3acb101 Compare July 29, 2025 04:22
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work! A few suggestions to improve readability.

@dduugg dduugg added this pull request to the merge queue Jul 30, 2025
@dduugg dduugg removed this pull request from the merge queue due to a manual request Jul 30, 2025
@dduugg dduugg force-pushed the dug/typed-cask-audit branch from 2885966 to 716968c Compare July 30, 2025 16:18
@dduugg dduugg enabled auto-merge July 30, 2025 16:18
@dduugg dduugg added this pull request to the merge queue Jul 30, 2025
@dduugg dduugg removed this pull request from the merge queue due to a manual request Jul 30, 2025
@dduugg dduugg force-pushed the dug/typed-cask-audit branch from 716968c to 157992b Compare July 30, 2025 19:43
@dduugg dduugg enabled auto-merge July 30, 2025 19:44
@dduugg dduugg added this pull request to the merge queue Jul 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2025
@dduugg dduugg added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit 7fb928c Jul 30, 2025
36 checks passed
@dduugg dduugg deleted the dug/typed-cask-audit branch July 30, 2025 20:37
@MikeMcQuaid
Copy link
Member

Thanks @dduugg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants