Skip to content

Fix type error in Readall.valid_tap? #20319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Fix type error in Readall.valid_tap? #20319

merged 1 commit into from
Jul 28, 2025

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Jul 27, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Noticed a tiny type error in Readall.valid_tap?, and figured I'd enable strict typing in OnSystem while I was in the vicinity.

@dduugg dduugg force-pushed the dug/fix-readall-type branch from 30c3c7a to 5c8d935 Compare July 27, 2025 17:04
@dduugg dduugg force-pushed the dug/fix-readall-type branch from 5c8d935 to c738d5c Compare July 27, 2025 17:07
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@MikeMcQuaid MikeMcQuaid enabled auto-merge July 28, 2025 08:18
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 28, 2025
Merged via the queue into main with commit 00c528b Jul 28, 2025
92 of 96 checks passed
@MikeMcQuaid MikeMcQuaid deleted the dug/fix-readall-type branch July 28, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants