Skip to content

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Jul 24, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It looks like the changes in #20300 may be too strict for how we should apply our codesign check. This PR utilises gktool which is the same check used by MacOS to confirm whether an application passes Gatekeeper or not.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@p-linnane p-linnane added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit a190b1f Jul 24, 2025
36 checks passed
@p-linnane p-linnane deleted the signing-audit branch July 24, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants