Replace ensure_formula_installed! with Formula#ensure_installed!
#20359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ensure_formula_installed!` requires the `Formula` class to be loaded before being called to work properly. Let's guarantee that instead by implementing it as an instance method of the `Formula` class. See discussion at #20358.
Bo98
approved these changes
Aug 1, 2025
https://github.com/Homebrew/brew/actions/runs/16683809174/job/47228527307?pr=20359#step:9:48 Seems like another race condition. |
This is close enough to #20331 to do now.
e3d48d2 to
fd80dd9
Compare
MikeMcQuaid
reviewed
Aug 2, 2025
| @@ -449,6 +449,8 @@ def redirect_stdout(file) | |||
| } | |||
| def ensure_formula_installed!(formula_name, reason: "", latest: false, | |||
| output_to_stderr: true, quiet: false) | |||
| odeprecated "ensure_formula_installed!", "Formula[\"#{formula_name}\"].ensure_installed!" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?ensure_formula_installed!requires theFormulaclass to be loadedbefore being called to work properly.
Let's guarantee that instead by implementing it as an instance method of
the
Formulaclass.See discussion at #20358.