extend/kernel: tighten up some type signatures #20356
Merged
+15
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Allowing either
Formula
e orString
s in these methods leads to errorsat runtime when one hasn't done
require "formula"
yet.Let's tighten these up so that they only accept
Formula
arguments toguarantee that
require "formula"
has been done before they are called.For callers that need to pass a
String
, we update them to call aversion of these methods that accepts only
String
s.See discussion at #20352.