download_queue: fix patch handling. #20353
Merged
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were being downloaded twice simultaneously which causes a locking race condition. While we're here, also improve the output of bottle manifests and patches in the download queue.
p-linnane
approved these changes
Aug 1, 2025
|
Not sure whether this is intentional or not, but there were no more bottle manifest files for recently installed/upgraded formulae in It turns out that, for instance, |
|
Probably not intentional, unfortunately. Can you open an issue? Or a fix is even better, if you're able to open a PR. Thanks! |
|
Should be fixed by #20370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were being downloaded twice simultaneously which causes a locking race condition.
While we're here, also improve the output of bottle manifests and patches in the download queue.
@carlocab should fix Homebrew/homebrew-core#231723 (comment)