formula_assertions: fix typechecking error in {shell,pipe}_output
#20345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cmd` can be a `Pathname` (see the type signature), but `ohai` seems to expect only `String`s now. While we're here, let's assert that `cmd` exists whenever it is a `Pathname`, to avoid passing arguments like `bin/"cmd --version"` (which is not a valid `Pathname`). See, for example, Homebrew/homebrew-core#231882.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typechecking error in the shell_output and pipe_output methods within formula_assertions.rb. The issue arises because ohai expects only String arguments, but these methods accept both Pathname and String types for the cmd parameter.
- Converts
cmdto string before passing toohaiusingcmd.to_s - Adds validation to ensure
Pathnamearguments actually exist on the filesystem - Prevents invalid usage patterns like
bin/"cmd --version"which creates invalid pathnames
MikeMcQuaid
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?cmdcan be aPathname(see the type signature), butohaiseems toexpect only
Strings now (because it callsFormatter.headline, whichonly accepts
Strings).While we're here, let's assert that
cmdexists whenever it is aPathname, to avoid passing arguments likebin/"cmd --version"(whichis not a valid
Pathname).See, for example, Homebrew/homebrew-core#231882.