Skip to content

Add ZeroZeroZeroZero cop #20233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Add ZeroZeroZeroZero cop #20233

merged 1 commit into from
Jul 11, 2025

Conversation

MikeMcQuaid
Copy link
Member

Add a new RuboCop to detect the use of 0.0.0.0 in formulae which indicates binding to all network interfaces, internally or externally, so is a bad default and potentially a security risk.

@MikeMcQuaid MikeMcQuaid force-pushed the zero_zero_zero_zero branch from 79cc9a9 to 3ae07a4 Compare July 10, 2025 16:41
@MikeMcQuaid MikeMcQuaid requested a review from carlocab July 10, 2025 16:41
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to limit this to homebrew-core given we don't allow taps to have custom rubocop configs?

@MikeMcQuaid
Copy link
Member Author

Do we want to limit this to homebrew-core given we don't allow taps to have custom rubocop configs?

Yes, good call, will do.

Add a new RuboCop to detect the use of 0.0.0.0 in formulae which
indicates binding to all network interfaces, internally or externally,
so is a bad default and potentially a security risk.

Co-authored-by: Issy Long <me@issylong.com>
@MikeMcQuaid MikeMcQuaid force-pushed the zero_zero_zero_zero branch from f6a0c90 to 71bab46 Compare July 11, 2025 07:24
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Jul 11, 2025
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Jul 11, 2025
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Jul 11, 2025
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 11, 2025
Merged via the queue into main with commit 36a4cb4 Jul 11, 2025
55 of 57 checks passed
@MikeMcQuaid MikeMcQuaid deleted the zero_zero_zero_zero branch July 11, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants