-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Add ZeroZeroZeroZero cop #20233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add ZeroZeroZeroZero cop #20233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
reviewed
Jul 10, 2025
79cc9a9
to
3ae07a4
Compare
p-linnane
approved these changes
Jul 10, 2025
carlocab
approved these changes
Jul 10, 2025
Bo98
approved these changes
Jul 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to limit this to homebrew-core given we don't allow taps to have custom rubocop configs?
issyl0
reviewed
Jul 10, 2025
Yes, good call, will do. |
Add a new RuboCop to detect the use of 0.0.0.0 in formulae which indicates binding to all network interfaces, internally or externally, so is a bad default and potentially a security risk. Co-authored-by: Issy Long <me@issylong.com>
f6a0c90
to
71bab46
Compare
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Jul 11, 2025
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Jul 11, 2025
MikeMcQuaid
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new RuboCop to detect the use of 0.0.0.0 in formulae which indicates binding to all network interfaces, internally or externally, so is a bad default and potentially a security risk.