Skip to content

feat: add update-perl-resources dev-cmd #20218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Conversation

daeho-ro
Copy link
Member

@daeho-ro daeho-ro commented Jul 6, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Update perl resources is really boring, so add update-perl-resources like python pypi.

@daeho-ro daeho-ro force-pushed the add-update-perl-resources branch from f31b9bd to f89ead0 Compare July 6, 2025 07:23
@carlocab carlocab requested a review from branchvincent July 6, 2025 10:55
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used this to update the resources in Homebrew/homebrew-core#229762 with no issues.

Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great to see this added! Left a few minor suggested tweaks

@daeho-ro daeho-ro force-pushed the add-update-perl-resources branch 3 times, most recently from 7dc1d82 to 1805ff9 Compare July 14, 2025 05:57
@daeho-ro daeho-ro force-pushed the add-update-perl-resources branch from 1805ff9 to 04dcca8 Compare July 14, 2025 12:20
@MikeMcQuaid
Copy link
Member

Let's give this a whirl and iterate. Thanks @daeho-ro!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit be806e4 Jul 15, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the add-update-perl-resources branch July 15, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants