Skip to content

bundle: Rename "brews" to "formulae" for consistency #20209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 4, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • Homebrew Bundle referred to formulae as "brews". But it referred to casks as "casks" and taps as "taps".
  • Let's use the same terminology everywhere.
  • (I know that brew "hello" is the formula syntax in the Brewfile, so I'm not changing that (though would be up for it, in a backwards compatible manner), just making the code more consistent.)

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Thanks @issyl0!

- Homebrew Bundle referred to formulae as "brews". But it referred to
  casks as "casks" and taps as "taps".
- Let's use the same terminology everywhere.
- (I know that `brew "hello"` is the formula syntax in the Brewfile, so
  I'm not changing that (though would be up for it, in a backwards
  compatible manner), just making the code more consistent.)
@issyl0 issyl0 force-pushed the bundle-rename-brews-to-formulae branch from 58d195b to 990c1ef Compare July 4, 2025 20:08
@issyl0
Copy link
Member Author

issyl0 commented Jul 4, 2025

Fixed the style issues. They didn't get detected in my editor, or autocorrected by brew style locally for some reason. 🤔

@issyl0 issyl0 marked this pull request as ready for review July 4, 2025 20:09
@issyl0 issyl0 enabled auto-merge July 4, 2025 20:12
@issyl0 issyl0 added this pull request to the merge queue Jul 4, 2025
Merged via the queue into main with commit 495b5be Jul 4, 2025
40 checks passed
@issyl0 issyl0 deleted the bundle-rename-brews-to-formulae branch July 4, 2025 20:36
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Technically these are kegs in some places and formulae in others but: the naming is certainly better than "brews".

@colindean
Copy link
Contributor

I just saw this in the release notes. Thanks for this work! It bothered me years ago but not enough to change it.

I think it'd be reasonable to add formula "hello" as a synonym for brew, maybe even internally swapping them, but eliminating brew would be too big of a breaking change to undertake without a really solid reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants