Optionally use DownloadQueue for reinstall, upgrade. #20296
Merged
+733
−625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dcebbe to
5a5b66a
Compare
9b2bb09 to
88af9cd
Compare
carlocab
approved these changes
Jul 24, 2025
Follow up on `DownloadQueue` for download concurrency on `brew fetch` and `brew install` to also add support for `brew reinstall` and `brew upgrade`. This required a fair bit of refactoring to make this work so I've also made `install.rb`, `reinstall.rb` and `upgrade.rb` `typed: strict` to add some extra guardrails from Sorbet here. Co-authored-by: Carlo Cabrera <github@carlo.cab>
0c3f5dd to
e10d4c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on
DownloadQueuefor download concurrency onbrew fetchandbrew installto also add support forbrew reinstallandbrew upgrade.This required a fair bit of refactoring to make this work so I've also made
install.rb,reinstall.rbandupgrade.rbtyped: strictto add some extra guardrails from Sorbet here.Because quite a lot of code needed reindented: I strongly recommend reviewing this without whitespace changes.
Apologies for the large diff.