Add JSON API download strategy for download queue #20289
Merged
+155
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rylan12
approved these changes
Jul 22, 2025
This fixes the weird/broken existing behaviour which was incorrectly creating symlinks at download time. It also defers much more logic to the original code. For clarity, rename the existing `API::Download` class to `API::SourceDownload`. While we're here: - add a/improve the `download_type` method on all `Downloadable` subclasses to improve download queue output format - move some logic to `RetryDownload`
8ca07ff to
ed5805e
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the weird/broken existing behaviour which was incorrectly creating symlinks at download time. It also defers much more logic to the original code.
For clarity, rename the existing
API::Downloadclass toAPI::SourceDownload.While we're here:
download_typemethod on allDownloadablesubclasses to improve download queue output formatRetryDownload