-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
cask/audit: always enable codesign audit #20286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5e50bc9
to
f96f8c0
Compare
f96f8c0
to
84d7000
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can limit it to official taps later. Or I can review it again once you do that, your call.
Is there value in allowing this to run in non-official taps, but just keep it behind the |
84d7000
to
cccec16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once 🟢, thanks @bevanjkay!
cccec16
to
c37d3e2
Compare
c37d3e2
to
1d6f486
Compare
1d6f486
to
9dc5929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should limit this to official taps.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This PR enables the codesigning audit for all casks. Currently this audit is only applied to new casks.
The audit is skipped when a cask is deprecated for any reason - so to unblock CI we will need to add a deprecation with reason
:unsigned
to any casks receiving updates that aren't codesigned.We need to be aware of some instances of false-positives with the audit, which include when binaries are placed in non-conventional locations within an app bundle. There may be improvements that could be made to the audit for these.
Paging @homebrew/cask as this is a fairly significant change.