Skip to content

Refactor DownloadQueue handling #20272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Refactor DownloadQueue handling #20272

merged 1 commit into from
Jul 18, 2025

Conversation

MikeMcQuaid
Copy link
Member

  • Use undocumented (for now) HOMEBREW_DOWNLOAD_CONCURRENCY instead of --concurrency flag and avoid passing around concurrency
  • Create and use Formula#enqueue_resources_and_patches helper method
  • Rename some method calls to be more obvious
  • Use Downloadable type to simplify type checks
  • General refactoring

Extracted from #20245

@MikeMcQuaid
Refactor DownloadQueue handling
a3d6ee1 
- Use undocumented (for now) `HOMEBREW_DOWNLOAD_CONCURRENCY` instead
  of `--concurrency` flag and avoid passing around `concurrency`
- Create and use `Formula#enqueue_resources_and_patches` helper method
- Rename some method calls to be more obvious
- Use `Downloadable` type to simplify type checks
- General refactoring
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit 042c79e Jul 18, 2025
34 checks passed
@MikeMcQuaid MikeMcQuaid deleted the refactor_download_queue branch July 18, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reitermarkus reitermarkus reitermarkus approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @reitermarkus @carlocab