Skip to content

Ignore IP allow list errors in too_many_open_prs #20263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

MTCoster
Copy link
Contributor

@MTCoster MTCoster commented Jul 16, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes https://github.com/orgs/Homebrew/discussions/6263.

Even when SAML passes, an IP allow list can still restrict access to organization repos.

I can't check off the test example below; not quite sure what unit testing this would look like.

Fixes https://github.com/orgs/Homebrew/discussions/6263. Even when SAML
passes, an IP allow list can still restrict access to organization
repos.
@MTCoster MTCoster force-pushed the pr-count-ip-allow-list branch from 607e0da to 41fce10 Compare July 16, 2025 12:52
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, nice work!

@MikeMcQuaid MikeMcQuaid enabled auto-merge July 16, 2025 14:24
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 16, 2025
Merged via the queue into Homebrew:main with commit 46ba380 Jul 16, 2025
36 checks passed
@MTCoster MTCoster deleted the pr-count-ip-allow-list branch July 17, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants