aliases/aliases: fix naming of symlinks #20246
Merged
+21
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
aliases/aliases.rb
in which it assumed that the filename of abrew alias
symlink in${HOMEBREW_PREFIX}/bin
was the name of the alias. The contents ofaliases/alias.rb
indicates otherwise: when an alias is first created, the script filename and its symlink have any non-alpahnumeric characters replaced with an underscore—presumably to avoid creating a file with a name starting with a hyphen—so e.g.brew alias test-command --edit
creates~/.brew-aliases/test_command
.No longer occurs:
brew alias
output showsbrew alias test_command
instead ofbrew alias test-command
brew alias
creates a newbrew-test_command
symlink in${HOMEBREW_PREFIX}/bin
beside the existingbrew-test-command
symlink, which also gets left behind ifbrew unalias test-command
is run