Skip to content

github_runner_matrix: fix skipped runner creation #20198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

github_runner_matrix: fix skipped runner creation #20198

merged 1 commit into from
Jul 1, 2025

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Need to create a new TestRunnerFormula instance under SimulateSystem to get a fresh read of its OS/arch requirements. Fixes #19838.

E.g. with intercal, which sets depends_on arch: :x86_64 only for macOS:

Before:

$ brew determine-test-runners intercal -d
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading intercal
==> Runners
[
  {
    "name": "Linux x86_64",
    "runner": "ubuntu-22.04",
    "container": {
      "image": "ghcr.io/homebrew/ubuntu22.04:main",
      "options": "--user=linuxbrew -e GITHUB_ACTIONS_HOMEBREW_SELF_HOSTED"
    },
    "workdir": "/github/home",
    "timeout": 2160,
    "cleanup": false,
    "testing_formulae": "intercal"
  },
  {
    "name": "macOS 15-x86_64",
    "runner": "15-x86_64-ASDF",
    "timeout": 120,
    "cleanup": false,
    "testing_formulae": "intercal"
  },
  {
    "name": "macOS 14-x86_64",
    "runner": "14-x86_64-ASDF",
    "timeout": 120,
    "cleanup": false,
    "testing_formulae": "intercal"
  },
  {
    "name": "macOS 13-x86_64",
    "runner": "13-x86_64-ASDF",
    "timeout": 120,
    "cleanup": false,
    "testing_formulae": "intercal"
  }
]

After:

$ brew determine-test-runners intercal -d
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading intercal
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading intercal
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading intercal
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading intercal
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading intercal
==> Runners
[
  {
    "name": "Linux x86_64",
    "runner": "ubuntu-22.04",
    "container": {
      "image": "ghcr.io/homebrew/ubuntu22.04:main",
      "options": "--user=linuxbrew -e GITHUB_ACTIONS_HOMEBREW_SELF_HOSTED"
    },
    "workdir": "/github/home",
    "timeout": 2160,
    "cleanup": false,
    "testing_formulae": "intercal"
  },
  {
    "name": "Linux arm64",
    "runner": "ubuntu-22.04-arm",
    "container": {
      "image": "ghcr.io/homebrew/ubuntu22.04:main",
      "options": "--user=linuxbrew -e GITHUB_ACTIONS_HOMEBREW_SELF_HOSTED"
    },
    "workdir": "/github/home",
    "timeout": 2160,
    "cleanup": false,
    "testing_formulae": "intercal"
  },
  {
    "name": "macOS 15-x86_64",
    "runner": "15-x86_64-ASDF",
    "timeout": 120,
    "cleanup": false,
    "testing_formulae": "intercal"
  },
  {
    "name": "macOS 14-x86_64",
    "runner": "14-x86_64-ASDF",
    "timeout": 120,
    "cleanup": false,
    "testing_formulae": "intercal"
  },
  {
    "name": "macOS 13-x86_64",
    "runner": "13-x86_64-ASDF",
    "timeout": 120,
    "cleanup": false,
    "testing_formulae": "intercal"
  }
]

@EricFromCanada EricFromCanada requested a review from Bo98 June 30, 2025 20:10
Bo98
Bo98 approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@EricFromCanada EricFromCanada force-pushed the determine-runner-arch branch from cb5c2c8 to 55ef890 Compare July 1, 2025 00:21
@EricFromCanada EricFromCanada enabled auto-merge July 1, 2025 00:33
EricFromCanada
EricFromCanada commented Jul 1, 2025
View reviewed changes
@EricFromCanada EricFromCanada added the help wanted We want help addressing this label Jul 1, 2025
@EricFromCanada EricFromCanada force-pushed the determine-runner-arch branch from 55ef890 to f92e961 Compare July 1, 2025 19:07
@EricFromCanada EricFromCanada removed the help wanted We want help addressing this label Jul 1, 2025
@EricFromCanada EricFromCanada added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 8520539 Jul 1, 2025
33 checks passed
@EricFromCanada EricFromCanada deleted the determine-runner-arch branch July 1, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew determine-test-runners may exclude runners for supported architectures
3 participants
@EricFromCanada @Bo98 @carlocab