Skip to content

Reapply "Make some of the bundle commands Sorbet typed: true" #20182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

Reapply "Make some of the bundle commands Sorbet typed: true" #20182

merged 2 commits into from
Jun 27, 2025
+21 −21

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jun 26, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
    • And brew typecheck --update this time to make sure Tapioca doesn't mess with the RBI file!
  • Have you successfully run brew tests with your changes locally?
  • This reverts commit 68dbf12 that was a revert of commit 68596ec because I put the RBI file in the wrong place and Tapioca got rid of it, causing this week's release to be blocked.

@issyl0
Reapply "Make some of the bundle commands Sorbet typed: true"
0d40f48 
- This reverts commit 68dbf12 that was
  a revert of commit 68596ec because I
  put the RBI file in the wrong place and Tapioca got rid of it, causing
  this week's release to be blocked.
Bo98
Bo98 approved these changes Jun 27, 2025
View reviewed changes
MikeMcQuaid
MikeMcQuaid approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it!

Bo98
Bo98 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@issyl0 issyl0 added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit c3ec61b Jun 27, 2025
33 checks passed
@issyl0 issyl0 deleted the some-bundle-files-werent-typed-at-all-but-now-some-are branch June 27, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@issyl0 @MikeMcQuaid @Bo98