Skip to content

Revert "Refine ask‐option dependency resolution and strengthen tests" #20181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Revert "Refine ask‐option dependency resolution and strengthen tests" #20181

wants to merge 2 commits into from

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Jun 26, 2025

Reverts #20033

This PR broke installs where multiple formulae are installed, and one depends on the other:

$ brew deps actionlint
gmp
shellcheck

$ brew install actionlint shellcheck
==> Downloading https://ghcr.io/v2/homebrew/core/actionlint/manifests/1.7.7
Already downloaded: /Users/rylanpolster/Library/Caches/Homebrew/downloads/1ca1e54d87168d51b4bde9fe9b01ab02142171ce76ace816438b0e0fd34aaad2--actionlint-1.7.7.bottle_manifest.json
==> Fetching dependencies for actionlint: shellcheck
==> Downloading https://ghcr.io/v2/homebrew/core/shellcheck/manifests/0.10.0
Already downloaded: /Users/rylanpolster/Library/Caches/Homebrew/downloads/939bfe6f0c1f854f0f44eb595c468ce80fe4741964900f4a22292a34eb148723--shellcheck-0.10.0.bottle_manifest.json
==> Fetching shellcheck
==> Downloading https://ghcr.io/v2/homebrew/core/shellcheck/blobs/sha256:5045be1e530288251353848343322f5a423617d061830b7ea7465fe550787364
Already downloaded: /Users/rylanpolster/Library/Caches/Homebrew/downloads/bdb405315351ac70325d9ef426750c1c17b59117921de4520bc76bc549785261--shellcheck--0.10.0.arm64_sequoia.bottle.tar.gz
==> Fetching actionlint
==> Downloading https://ghcr.io/v2/homebrew/core/actionlint/blobs/sha256:8d94522b3eefa067708c2ffe00f95a3b7ea39180a5399ec2f570f021228fabe2
Already downloaded: /Users/rylanpolster/Library/Caches/Homebrew/downloads/701e080a2852dbe152b6422296189fbd3f395c3b5c0cf5fb8b7c373c037250bd--actionlint--1.7.7.arm64_sequoia.bottle.tar.gz
==> Installing dependencies for actionlint: shellcheck
==> Installing actionlint dependency: shellcheck
==> Downloading https://ghcr.io/v2/homebrew/core/shellcheck/manifests/0.10.0
Already downloaded: /Users/rylanpolster/Library/Caches/Homebrew/downloads/939bfe6f0c1f854f0f44eb595c468ce80fe4741964900f4a22292a34eb148723--shellcheck-0.10.0.bottle_manifest.json
==> Pouring shellcheck--0.10.0.arm64_sequoia.bottle.tar.gz
🍺  /opt/homebrew/Cellar/shellcheck/0.10.0: 8 files, 67.5MB
==> Installing actionlint
==> Pouring actionlint--1.7.7.arm64_sequoia.bottle.tar.gz
🍺  /opt/homebrew/Cellar/actionlint/1.7.7: 8 files, 5.0MB
==> Running `brew cleanup actionlint`...
==> Downloading https://ghcr.io/v2/homebrew/core/shellcheck/manifests/0.10.0
Already downloaded: /Users/rylanpolster/Library/Caches/Homebrew/downloads/939bfe6f0c1f854f0f44eb595c468ce80fe4741964900f4a22292a34eb148723--shellcheck-0.10.0.bottle_manifest.json
Error: Formula installation already attempted: shellcheck

CC @tyuwags

@Rylan12 Rylan12 enabled auto-merge June 26, 2025 20:58
@Rylan12
Copy link
Member Author

Rylan12 commented Jun 26, 2025 

For the Links > External check, the following failures were found:

* At ./_site/Gems,-Eggs-and-Perl-Modules.html:159:

  External link https://metacpan.org/pod/local::lib failed (status code 406)

* At ./_site/Gems,-Eggs-and-Perl-Modules.html:167:

  External link https://metacpan.org/pod/local::lib failed (status code 406)


HTML-Proofer found 2 failures!

Works fine locally. Not sure how to deal with these long-term, so for now I'm just going to remove the links.

@p-linnane
Copy link
Member

@Rylan12 I've seen these 406 error intermittently. A rerun usually works.

@Rylan12
Copy link
Member Author

Rylan12 commented Jun 26, 2025 •
edited
Loading

@p-linnane It's been run 3 times already, still failing. Any suggestions?

@p-linnane
Copy link
Member

Not sure. A rerun or two have worked for me.

We should really change failures from external links into warnings or something. It's rough having our CI failing due to links we don't control.

@Rylan12
Copy link
Member Author

Rylan12 commented Jun 26, 2025

And... hit by the flaky svn test again 🤦

I'll get this through eventually

@tyuwags
Copy link
Contributor

tyuwags commented Jun 26, 2025

sorry, just saw that, I know why it broke
on upgrade,

brew/Library/Homebrew/upgrade.rb

Line 294 in 4fd7c6f

formulae_to_install = formulae.dup
, I change this line

installed_formulae = dry_run ? formulae : FormulaInstaller.installed.to_a

to this

installed_formulae = formulae.dup

so if a duplicate exists, as you showed, because of dependants, it wasn't remove
I change that because FormulaInstaller.installed.to_a was empty as no install was made and I needed it to be already specified, didn't thought about dependants already in it

@Rylan12 Rylan12 added this pull request to the merge queue Jun 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 26, 2025
tyuwags added a commit to tyuwags/brew that referenced this pull request Jun 26, 2025
@tyuwags
correcting error of installation dependency
9e131d0 
resolves Homebrew#20181
@MikeMcQuaid
Copy link
Member

There's now a conflict here so let's try to fix forward in #20183.

Thanks for PR @Rylan12!

@carlocab carlocab deleted the revert-20033-master branch June 27, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rylan12 @p-linnane @tyuwags @MikeMcQuaid @carlocab