Skip to content

Revert "Make some of the bundle commands Sorbet typed: true" #20158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Revert "Make some of the bundle commands Sorbet typed: true" #20158

merged 1 commit into from
Jun 23, 2025

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jun 23, 2025 •
edited
Loading

Reverts #20145

See #20149

@MikeMcQuaid MikeMcQuaid requested a review from issyl0 June 23, 2025 12:52
@MikeMcQuaid MikeMcQuaid enabled auto-merge June 23, 2025 12:53
issyl0
issyl0 approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, sorry.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 23, 2025
Merged via the queue into master with commit c19f08b Jun 23, 2025
33 checks passed
@MikeMcQuaid MikeMcQuaid deleted the revert-20145-some-bundle-files-werent-typed-at-all-but-now-some-are branch June 23, 2025 13:18
@MikeMcQuaid
Copy link
Member Author

@issyl0 No sorry needed! These things happen and there's a strong argument that our CI should be catching this sort of thing in the PR itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issyl0 issyl0 issyl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @issyl0