Skip to content

Add strict parameter to GitHub::check_for_duplicate_pull_requests #20082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Add strict parameter to GitHub::check_for_duplicate_pull_requests #20082

merged 1 commit into from
Jun 12, 2025

Conversation

alex
Copy link
Contributor

@alex alex commented Jun 11, 2025 •
edited by MikeMcQuaid
Loading

Fixes #19828

Rylan12
Rylan12 reviewed Jun 12, 2025
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great! One change for consistent messages:

@Rylan12 Rylan12 requested a review from woodruffw June 12, 2025 00:27
@Rylan12 Rylan12 changed the title fixes #19828 -- added a strict parameter to GitHub::check_for_duplicate_pull_requests Add strict parameter to GitHub::check_for_duplicate_pull_requests Jun 12, 2025
@Rylan12 Rylan12 linked an issue Jun 12, 2025 that may be closed by this pull request
GitHub::check_for_duplicate_pull_requests should have a strict failure mode #19828
Closed
1 task
@alex alex force-pushed the strict-check-for-duplicate-prs branch from c2daab8 to 0bd9d70 Compare June 12, 2025 01:38
p-linnane
p-linnane approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex!

MikeMcQuaid
MikeMcQuaid requested changes Jun 12, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alex!

Where is this strict parameter being used/set to true?

Note that this is not (currently at least) either an internal or public API. If it's needed elsewhere: let's make it an internal or public API, accordingly.

@alex
Copy link
Contributor Author

alex commented Jun 12, 2025

This is for brew-pip-audit, #19828 has the additional context. Right now it's sending duplicate PRs (see, https://github.com/Homebrew/homebrew-core/pulls?q=is%3Aopen+is%3Apr+label%3Apip-audit) which is :-(

@MikeMcQuaid
Copy link
Member

@alex Ok, thanks. Could you add a # @api internal along with some basic documentation to this function?

@alex alex force-pushed the strict-check-for-duplicate-prs branch from 0bd9d70 to efa0c95 Compare June 12, 2025 12:45
@alex
Copy link
Contributor Author

alex commented Jun 12, 2025

Let me know if this matches what you were looking for, or if you wanted more detail.

MikeMcQuaid
MikeMcQuaid approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again @alex!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 12, 2025
@alex
Copy link
Contributor Author

alex commented Jun 12, 2025

Of course, thanks for the review!

Merged via the queue into Homebrew:master with commit 1a5afaf Jun 12, 2025
33 checks passed
@alex alex deleted the strict-check-for-duplicate-prs branch June 12, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rylan12 Rylan12 Rylan12 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@p-linnane p-linnane p-linnane approved these changes

@woodruffw woodruffw Awaiting requested review from woodruffw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub::check_for_duplicate_pull_requests should have a strict failure mode
4 participants
@alex @MikeMcQuaid @Rylan12 @p-linnane