Only generate cask variations for supported macOS configurations #20080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2b4b1a to
f82d365
Compare
f82d365 to
510e189
Compare
510e189 to
e5667cb
Compare
MikeMcQuaid
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #20075
This PR fixes the issue where
Cask#to_hash_from_variationsincludes variations that are not allowable given thedepends_on macos:ordepends_on arch:rules. Now, we also check whether the current variation OS is allowable after refreshing the Cask, as we cannot determine whether the given OS is supported otherwise.CC: @EricFromCanada