Skip to content

workflows/tests.yml: more CI tweaks. #20060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

workflows/tests.yml: more CI tweaks. #20060

merged 1 commit into from
Jun 9, 2025

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jun 9, 2025 •
edited
Loading

  • use macos-15 for tap syntax, no reason to use (old) macos-14
  • use macos-latest for all macOS jobs where we're only testing a single macOS and single Linux target
  • add test default formula jobs for Linux arm64
  • rename a few more jobs for consistency and clarity

@MikeMcQuaid MikeMcQuaid force-pushed the more_ci_tweaks branch 8 times, most recently from 5a065db to e54f0a0 Compare June 9, 2025 15:10
@Bo98
Copy link
Member

Bo98 commented Jun 9, 2025 •
edited
Loading

There's extra env filtering here that may need adjusting for the testing envs we're using:

brew/Library/Homebrew/test/support/helper/spec/shared_context/integration_test.rb

Lines 77 to 86 in 97bc7b1

env.merge!(
"PATH" => path,
"HOMEBREW_PATH" => path,
"HOMEBREW_BREW_FILE" => HOMEBREW_PREFIX/"bin/brew",
"HOMEBREW_INTEGRATION_TEST" => command_id,
"HOMEBREW_TEST_TMPDIR" => TEST_TMPDIR,
"HOMEBREW_DEV_CMD_RUN" => "true",
"HOMEBREW_USE_RUBY_FROM_PATH" => ENV.fetch("HOMEBREW_USE_RUBY_FROM_PATH", nil),
"GEM_HOME" => nil,
)

@MikeMcQuaid MikeMcQuaid force-pushed the more_ci_tweaks branch 2 times, most recently from e5df708 to 90bcc46 Compare June 9, 2025 16:15
@MikeMcQuaid
workflows/tests.yml: more CI tweaks.
63abe0b 
- use `macos-15` for tap syntax, no reason to use (old) `macos-14`
- use `macos-latest` for all macOS jobs where we're only testing a
  single macOS and single Linux target
- add `test default formula` jobs for Linux `arm64`
- rename a few more jobs for consistency and clarity
@MikeMcQuaid
Copy link
Member Author

Backed out brew tests on arm64: I personally don't care enough and can't figure it out. This will at least add the brew test-bot tests there.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 9, 2025
Merged via the queue into master with commit 8ebb2cd Jun 9, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the more_ci_tweaks branch June 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @Bo98 @carlocab