cask_loader: improve error handling. #20057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32b536e to
a81c0b0
Compare
Handle weird edge cases where we try to read a cask from invalid paths.
a81c0b0 to
e7f667c
Compare
Rylan12
approved these changes
Jun 6, 2025
|
@Rylan12 Yeh, think it might be worth considering as part of your internal API work when it's further along? Don't think it makes sense to do before that just from the perspective of the current schema going to change 🔜. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle weird edge cases where we try to read a cask from invalid paths.
Fixes #19142