Skip to content

bin/brew: don't copy across zeroed env values. #20053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

bin/brew: don't copy across zeroed env values. #20053

merged 1 commit into from
Jun 5, 2025

Conversation

MikeMcQuaid
Copy link
Member

Fixes #20049

@MikeMcQuaid MikeMcQuaid enabled auto-merge June 5, 2025 07:33
Rylan12
Rylan12 approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 5, 2025
Merged via the queue into master with commit 485f1ab Jun 5, 2025
35 checks passed
@MikeMcQuaid MikeMcQuaid deleted the skip_zero_values branch June 5, 2025 07:53
@paulehoffman
Copy link

That was fast; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Having export NO_COLOR=0 in .bashrc causes brew commands to fail
3 participants
@MikeMcQuaid @paulehoffman @Rylan12