Skip to content

brew (bundle|) sh: use user's configuration but override prompts. #20047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

brew (bundle|) sh: use user's configuration but override prompts. #20047

merged 1 commit into from
Jun 5, 2025

Conversation

MikeMcQuaid
Copy link
Member

This was more painful that I expected but will allow brew bundle sh and brew sh to use the user's configuration but use our custom prompt for Bash and ZSH.

Bo98
Bo98 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok but sounds like it might override any PATH we set in brew bundle which we probably don't want?

@MikeMcQuaid
Copy link
Member Author

Seems ok but sounds like it might override any PATH we set in brew bundle which we probably don't want?

@Bo98 Good point. That seems like another thing that could be handled with the .zsh/.bash files?

@Bo98
Copy link
Member

Bo98 commented Jun 4, 2025

That seems like another thing that could be handled with the .zsh/.bash files?

Main concern being there will be rc files with PATH=/opt/homebrew/bin:$PATH (or similar) which may override HOMEBREW_BUNDLE_FORMULA_VERSION_*.

@MikeMcQuaid
Copy link
Member Author

Main concern being there will be rc files with PATH=/opt/homebrew/bin:$PATH (or similar) which may override HOMEBREW_BUNDLE_FORMULA_VERSION_*.

Gotcha. Fixed now with addition of BREW_PROMPT_PATH.

@MikeMcQuaid MikeMcQuaid enabled auto-merge June 5, 2025 07:49
@MikeMcQuaid
brew (bundle|) sh: use user's configuration but override prompts.
5fe43ed 
This was more painful that I expected but will allow `brew bundle sh`
and `brew sh` to use the user's configuration but use our custom prompt
for Bash and ZSH.
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 5, 2025
Merged via the queue into master with commit 1d2f045 Jun 5, 2025
35 checks passed
@MikeMcQuaid MikeMcQuaid deleted the brew_sh_profiles branch June 5, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @Bo98