Skip to content

fix: Don't invalidate the cached location if the response is a redirect #19723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

fix: Don't invalidate the cached location if the response is a redirect #19723

merged 1 commit into from
Apr 9, 2025

Conversation

boblail
Copy link
Contributor

@boblail boblail commented Apr 8, 2025 •
edited
Loading

A bug introduced with #19460 is that if a redirection has a file size (for example, if it is a 302 that also has HTML content), Homebrew will invalidate the cached location.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@boblail
fix: Don't invalidate the cached location if the response is a redirect
a6a8306 
A bug introduced with Homebrew#19460 is that if a redirection has a file size (for example, if it is a 302 that also has HTML content), Homebrew will invalidate the cached location.
MikeMcQuaid
MikeMcQuaid approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @boblail!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Apr 9, 2025
Merged via the queue into Homebrew:master with commit 35897fe Apr 9, 2025
38 checks passed
@boblail
Copy link
Contributor Author

boblail commented Apr 9, 2025

Thanks @MikeMcQuaid!

@EricFromCanada EricFromCanada mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boblail @MikeMcQuaid