Skip to content

Trying to comply with new cargo clippy #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2022
Merged

Trying to comply with new cargo clippy #181

merged 2 commits into from
Oct 10, 2022

Conversation

ThomasByr
Copy link
Contributor

@ThomasByr ThomasByr commented Sep 2, 2022 •
edited
Loading

this comes from:

cargo clippy --all-targets --all-features -- -D clippy::all
  • found many .push_str(format!(...)) and replaced them with writeln!(...)
  • some unnecessary return {...}; (removed "return" and ";")
  • .get(0) becomes .first() on Vec<>

@ThomasByr
Copy link
Contributor Author

i also added a small fix for two hard coded ";compile" that shouldn't break anything

@ThomasByr ThomasByr changed the title Try to comply with new cargo clippy Trying to comply with new cargo clippy Sep 3, 2022
@Headline Headline added the hacktoberfest-accepted opt-in for hacktoberfest prs label Oct 10, 2022
@Headline Headline merged commit 86407bb into Headline:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted opt-in for hacktoberfest prs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasByr @Headline