Skip to content

Track actual path position for path.Path<Params> #11405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2023
Merged

Track actual path position for path.Path<Params> #11405

merged 2 commits into from
Nov 22, 2023

Conversation

Simn
Copy link
Member

@Simn Simn commented Nov 22, 2023 •
edited
Loading

This may look a bit excessive but finally deals with annoying issue #7282#9705. Type paths can now also store the actual dot path without the type parameters, which was impossible to determine before.

Edit: I really like how obvious pretty errors make this change:

  1 | class User extends ThisObviouslyDoesntExist<T> {}
-   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |                    ^^^^^^^^^^^^^^^^^^^^^^^^
    | Type not found : ThisObviouslyDoesntExist

@Simn Simn merged commit 2fbb4bf into development Nov 22, 2023
@Simn Simn deleted the placed_type_path_pos_path branch November 22, 2023 11:09
@Simn Simn mentioned this pull request Nov 22, 2023
Closed
@skial skial mentioned this pull request Nov 28, 2023
Closed
1 task
0b1kn00b pushed a commit to 0b1kn00b/haxe that referenced this pull request Jan 25, 2024
@Simn
Track actual path position for path.Path<Params> (HaxeFoundation#11405
5cf7a85 
)

* turn placed_type_path into a record and add pos_path

* fix Rudy
@kLabz kLabz mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simn @kLabz