Skip to content

[core] Fixed problems found by thread and memory sanitizers #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2025
Merged

[core] Fixed problems found by thread and memory sanitizers #3166

merged 4 commits into from
May 21, 2025

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented May 7, 2025

Changes:

  1. Fixed removal of all groups in the procedure of total removal (called from CUDTUnited::cleanup). That was reported as a leak.
  2. Fixed access of m_QueuedSockets without m_AcceptLock.
  3. Fixed usage of CUDT::m_stats.tsStartTime without m_StatsLock.
  4. Getting option by asking the first socket: untangled the lock order of m_GroupLock and m_GlobControlLock; changed the order by attempting to extract the socket by ID after taking it from the group member container.
  5. test: change variable to atomic to avoid data race.

@ethouris ethouris added this to the v1.5.5 milestone May 7, 2025
@ethouris ethouris added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels May 7, 2025
zerodefect
zerodefect reviewed May 16, 2025
View reviewed changes
srtcore/group.cpp Outdated
leaveCS(m_GroupLock);
if (sk.socket)
// CUDTUnited::m_GlobControlLock can't be acquired with m_GroupLock either.
// We have also no guarantee that after leacing m_GroupLock the socket isn't
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leacing => leaving?

ethouris
ethouris commented May 16, 2025
View reviewed changes
@cl-ment cl-ment merged commit 21370a7 into Haivision:master May 21, 2025
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zerodefect zerodefect zerodefect left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@ethouris @zerodefect @cl-ment