Skip to content

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Mar 10, 2025

Fixes #3131

Catches the case when the handshake response has come without the packetfilter extension, while it was configured on the agent:

  • On caller, if the caller has configured packetfilter, and listener responded without it, reject the connection: this should never happen in case when the listener is in the version that supports packetfilter, while allowing the connection could cause confusion during transmission and some silent runtime errors
  • On listener, if the listener configured packetfilter, but the caller did not request it, allow the connection without packetfilter

@ethouris ethouris added this to the v1.5.5 milestone Mar 10, 2025
@cl-ment cl-ment self-requested a review March 10, 2025 16:40
@ethouris ethouris added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Mar 11, 2025
@ethouris ethouris requested a review from maxsharabayko March 12, 2025 09:41
@cl-ment cl-ment merged commit f8e1bd6 into Haivision:master Mar 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FEC-configured connection is not rejected when the peer doesn't support it and results in potential data corruption
3 participants