Fixed Deriving and Getting the StreamID Socket Option on a Group #3075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…storage. The storage could have empty strings, and dereferencing the first element must not happen.
SRTO_STREAMID, SRTO_PACKETFILTER are directly affected. SRTO_PASSPHRASE was derived correctly.
524bb5b to
5b289a1
Compare
|
v1.5.4 Release Build on a local host. Note "Stream ID: not set" is reported by the receiver upon connection ( (sender)
$> srt-xtransmit generate "srt://127.0.0.1:4200?grouptype=broadcast&streamid=abcdefg" --duration 1s --sendrate 100kbps
15:20:33.484373 [I] CONN Establishing connection no.1.
15:20:33.496851 [I] PACER sendrate 100000 bps (inter send interval 106382 us)
15:20:34.574192 [I] PIPE Pipe exit (conn @2093138386), 0 remain active.
(receiver)
$> srt-xtransmit receive srt://:4200?groupconnect=1
15:20:22.741243 [I] CONN Establishing connection no.1.
15:20:22.748278 [I] SOCKET::SRT srt://:4200: bound to ':4200'.
15:20:33.495838 [I] SOCKET::SRT @268705253 (srt://:4200) Accepted connection @1342447075. TSBPD Latency RCV 120ms, peer 0ms. KM state UNSECURED (RCV UNSECURED, SND UNSECURED). PB key length: 0. Cryptomode AUTO. Stream ID: not set.
15:20:34.872000/T87372*E:SRT.gr: grp/recv: $1342447075: ABANDONING: opened=false connected=false
15:20:34.872917 [W] RECEIVE read::recv: Connection does not exist
15:20:34.873611 [I] PIPE Pipe exit (conn @1342447075), 0 remain active.With PR 3075 the Stream ID is correct ( $> srt-xtransmit receive srt://:4200?groupconnect=1
15:33:02.551876 [I] CONN Establishing connection no.1.
15:33:02.556806 [I] SOCKET::SRT srt://:4200: bound to ':4200'.
15:33:03.495007 [I] SOCKET::SRT @700298265 (srt://:4200) Accepted connection @1774040087. TSBPD Latency RCV 120ms, peer 0ms. KM state UNSECURED (RCV UNSECURED, SND UNSECURED). PB key length: 0. Cryptomode AUTO. Stream ID: abcdefg.
15:33:04.579000/T71984*E:SRT.gr: grp/recv: $1774040087: ABANDONING: opened=false connected=false
15:33:04.580929 [W] RECEIVE read::recv: Connection does not exist
15:33:04.581270 [I] PIPE Pipe exit (conn @1774040087), 0 remain active. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDTGroup::getOpt(..): check value length in group config storage. The storage could have empty strings, and dereferencing the first element must not happen.Fixes #3072.