Skip to content

[apps] Fixed URI decoding in UriParser #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

[apps] Fixed URI decoding in UriParser #3041

merged 2 commits into from
Oct 8, 2024

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Oct 7, 2024 •
edited
Loading

The uri_decode function wasn't interpreting the % sequence properly if the value was 00 and stopped on the first error.

The fix:

  • %00 is properly interpreted as a NUL character
  • If the % coding syntax is erroneous, the % character is shipped as is and parsing continues since the next character

@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Oct 8, 2024
@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core [apps] Area: Test applications related improvements and removed [core] Area: Changes in SRT library core labels Oct 8, 2024
@maxsharabayko maxsharabayko merged commit 8f6fd4e into Haivision:master Oct 8, 2024
12 checks passed
@maxsharabayko maxsharabayko mentioned this pull request Oct 8, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[apps] Area: Test applications related improvements Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ethouris @maxsharabayko