[core] Fix a data race #2984
Closed
[core] Fix a data race #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved syntax Changed lock/unlock functions name to match reference implementation Add unit tests for SharedMutex
Add a CSharedObject template class that protects an object
|
To keep track, this PR misses the very data race fix originally done in #2961. The proposed fix was in locking try
{
+ ScopedLock col(ls->core().m_ConnectionLock);
ns = new CUDTSocket(*ls);
// No need to check the peer, this is the address from which the request has come.
ns->m_PeerAddr = peer;The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #PR2981
Add a shared mutex on m_pListener to avoid a data race condition.
This fixes #2970