[core] Set ACK position based on RCV buffer first nonread seqno. #2931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
commented
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental proposal for issue #2881.
The
CRcvBuffer::getFirstNonreadSeqNo()returns the sequence number of the first packet that cannot be read from the buffer. This includes the first missing packet and the first packet of a several packets long message, if not all packets of the message exist yet. Due to the latter case, the proposed solution is not accurate in a message mode of SRT when TSBPD is disabled. When TSBPD is enabled, a message must always be one packet long.There is a broader rework of the RCV buffer in PR #2527. However it may not end up in v1.5.4 due to some testing already performed with the existing RCV buffer implementation. Therefore this PR may be considered a temporal fix of #2881 until #2527 is merged.