[core] Removed the possibility to use optlen==-1 for null terminated strings in srt_setsockopt #2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ethouris
approved these changes
Jan 11, 2024
maxsharabayko
requested changes
Jan 12, 2024
… for an incorrect reason
maxsharabayko
approved these changes
Jan 25, 2024
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2849 +/- ##
==========================================
+ Coverage 67.04% 67.34% +0.29%
==========================================
Files 102 103 +1
Lines 20368 20459 +91
==========================================
+ Hits 13656 13778 +122
+ Misses 6712 6681 -31 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in srt_setsockopt so that it returns SRT_EINVPARAM when optlen is -1 (see #2845)
Added an unit test to verify this behaviour