[BUG/TEST] Refaxed and fixed multiplexer reusage. Fixed ReuseAddr tests. #2608

ethouris · 2023-01-11T16:06:42Z

Fixes #2389

Changes:

Reworked the procedure of finding the matching or conflicting multiplexer (some IPv6-related cases were incorrectly checking the cases of IPv6 only and IPv6+IPv4).
Obtaining the IPPROTO_IPV6/IPV6_V6ONLY flag from the socket in case of AF_INET6 family just after socket creation so that this flag can be checked when searching for a matching multiplexer binding.
Reworked and fixed UT for ReuseAddr.* - removed or put under a better control tests that were relying on a half-cleanedup previously bound sockets.

…ing due to earlier closed socket

…ng source address for unspecified address

…v4. Added Wildcard6 test to do the same in case when local IP is IPv6 only

…n binding to ::.

…tforms that do not support IPv6

…Pv6. Updated the test accordingly

docs/API/API-functions.md

docs/API/API-socket-options.md

Co-authored-by: stevomatthews <smatthews@haivision.com>

codecov-commenter · 2023-01-26T11:40:47Z

Codecov Report

Merging #2608 (d777686) into master (30f6f6b) will decrease coverage by 0.51%.
The diff coverage is 52.02%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   66.53%   66.03%   -0.51%     
==========================================
  Files          99       99              
  Lines       19843    20043     +200     
==========================================
+ Hits        13203    13235      +32     
- Misses       6640     6808     +168

Impacted Files	Coverage Δ
srtcore/api.h	`96.55% <ø> (ø)`
srtcore/channel.cpp	`43.42% <0.00%> (-2.21%)`	⬇️
srtcore/channel.h	`0.00% <0.00%> (ø)`
srtcore/api.cpp	`52.72% <41.53%> (-0.48%)`	⬇️
test/test_reuseaddr.cpp	`64.85% <58.76%> (-15.44%)`	⬇️
srtcore/socketconfig.h	`90.00% <100.00%> (+0.16%)`	⬆️
srtcore/list.cpp	`76.69% <0.00%> (-9.28%)`	⬇️
srtcore/window.h	`96.72% <0.00%> (-3.28%)`	⬇️
haicrypt/hcrypt_tx.c	`17.14% <0.00%> (-1.28%)`	⬇️
srtcore/core.cpp	`60.92% <0.00%> (-0.33%)`	⬇️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docs/API/API-functions.md

docs/API/API-socket-options.md

srtcore/api.cpp

srtcore/socketconfig.h

srtcore/api.cpp

stevomatthews · 2023-01-31T20:41:42Z

Review pass completed with minor edits/suggestions.

docs/API/API-functions.md

Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>

srtcore/api.h

srtcore/api.cpp

Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>

docs/API/API-functions.md

Co-authored-by: stevomatthews <smatthews@haivision.com>

Refaxed and fixed multiplexer reusage. Fixed ReuseAddr tests.

1cfe0e5

ethouris requested a review from maxsharabayko January 11, 2023 16:06

Small fix for an unlikely case of accepting from a closed listener

8b4352c

ethouris marked this pull request as ready for review January 11, 2023 18:00

Mikołaj Małecki added 10 commits January 11, 2023 19:11

Withdrawn resetting sync before closing - useless and not always work…

5c5d2dc

…ing due to earlier closed socket

Fixed mux reusage for IPv6. Added IPv6 SameAddr test. Fixed not setti…

6644c75

…ng source address for unspecified address

Fixed: local IP filtering as default local addr not always must be IP…

adfda78

…v4. Added Wildcard6 test to do the same in case when local IP is IPv6 only

Updated documentation. Added trial fix to reject undefined V6ONLY whe…

3ba87f9

…n binding to ::.

Fixed problematic CMSG handling in case of IPv4+IPv6 and mapped IPv4

066a4d8

Changed threads to futures to allow for assertions in threads

b855a30

Removed unused constant that caused failure on Windows

5aea54f

Fixed for systems with weird msg flags definitions

200e7c1

Improved test marks to better identify tests to be excluded on CI pla…

ef64980

…tforms that do not support IPv6

Enforced async policy for async call to prevent spawning caller too late

abe939e

ethouris requested a review from stevomatthews January 25, 2023 09:03

Mikołaj Małecki added 2 commits January 25, 2023 13:33

Enabled check if SRTO_IPV6ONLY option is set before omni binding in I…

18db3c8

…Pv6. Updated the test accordingly

Merge branch 'master' into dev-fix-reuseaddr-test

6edddf3

ethouris marked this pull request as draft January 25, 2023 13:20

Cleaned up markers and unused code

a3fb814

ethouris force-pushed the dev-fix-reuseaddr-test branch from feceb88 to a3fb814 Compare January 25, 2023 13:24

ethouris marked this pull request as ready for review January 25, 2023 13:24

maxsharabayko added this to the v1.5.2 milestone Jan 25, 2023

maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Jan 25, 2023

ethouris mentioned this pull request Jan 25, 2023

[BUG] Fixed PKTINFO case that was failing for IPv4+IPv6 bound sockets #2630

Merged

stevomatthews reviewed Jan 25, 2023

View reviewed changes

docs/API/API-functions.md Outdated Show resolved Hide resolved