Skip to content

[build] Use GTest from brew in MacOS action. #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 10, 2023
Merged

[build] Use GTest from brew in MacOS action. #2607

merged 5 commits into from
Jan 10, 2023

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Jan 10, 2023 •
edited
Loading

Fixes the MacOS GitHub Action build error seen lately:

googletest-src/googlemock/include/gmock/gmock-actions.h:455:3: error: definition of implicit copy constructor for 'PolymorphicAction<testing::internal::ReturnNullAction>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  GTEST_DISALLOW_ASSIGN_(PolymorphicAction);
  ^
/Users/runner/work/srt/srt/_build/googletest/googletest-src/googletest/include/gtest/internal/gtest-port.h:682:8: note: expanded from macro 'GTEST_DISALLOW_ASSIGN_'
  void operator=(type const &) = delete
       ^
/Users/runner/work/srt/srt/_build/googletest/googletest-src/googlemock/include/gmock/gmock-actions.h:[101](https://github.com/Haivision/srt/actions/runs/3877271627/jobs/6620352411#step:4:102)1:10: note: in implicit copy constructor for 'testing::PolymorphicAction<testing::internal::ReturnNullAction>' first required here
  return MakePolymorphicAction(internal::ReturnNullAction());
         ^
/Users/runner/work/srt/srt/_build/googletest/googletest-src/googlemock/include/gmock/gmock-actions.h:455:3: error: definition of implicit copy constructor for 'PolymorphicAction<testing::internal::ReturnVoidAction>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  GTEST_DISALLOW_ASSIGN_(PolymorphicAction);
  ^
/Users/runner/work/srt/srt/_build/googletest/googletest-src/googletest/include/gtest/internal/gtest-port.h:682:8: note: expanded from macro 'GTEST_DISALLOW_ASSIGN_'
  void operator=(type const &) = delete
       ^
/Users/runner/work/srt/srt/_build/googletest/googletest-src/googlemock/include/gmock/gmock-actions.h:1016:10: note: in implicit copy constructor for 'testing::PolymorphicAction<testing::internal::ReturnVoidAction>' first required here
  return MakePolymorphicAction(internal::ReturnVoidAction());
         ^

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [build] Area: Changes in build files labels Jan 10, 2023
@maxsharabayko maxsharabayko added this to the v1.5.2 milestone Jan 10, 2023
@maxsharabayko maxsharabayko changed the title [build] Upgraded GTest to v1.12.0. [build] Install GTest from brew in MacOS action. Jan 10, 2023
@maxsharabayko maxsharabayko changed the title [build] Install GTest from brew in MacOS action. [build] Use GTest from brew in MacOS action. Jan 10, 2023
@maxsharabayko maxsharabayko merged commit a08a42c into Haivision:master Jan 10, 2023
@maxsharabayko maxsharabayko deleted the build/gtest-1-12 branch January 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[build] Area: Changes in build files Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.
1 participant
@maxsharabayko