Skip to content

[build] Disable ConnectionTimeout test (blocking), Win GitHub Action. #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2022
Merged

[build] Disable ConnectionTimeout test (blocking), Win GitHub Action. #2543

merged 2 commits into from
Nov 18, 2022

Conversation

maxsharabayko
Copy link
Collaborator

The test TestConnectionTimeout.BlockingLoop keeps failing in GitHub Action Windows.
It seems related to VM changes, because re-running the test for v1.4.4 in GitHub Action Win also led to the test failure, while previously it was passing.
The test is also passing on a local Windows machine.

I find nothing more clever to do except disable the test in Windows GitHub Action.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [build] Area: Changes in build files labels Nov 17, 2022
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 17, 2022
@ethouris
Copy link
Collaborator

The --gtest_filter is an option for the test executable, not for ctest command.

       -E <regex>, --exclude-regex <regex>
              Exclude tests matching regular expression.

              This option tells CTest to NOT run the tests whose names match the given regular expression.

@codecov-commenter

This comment was marked as off-topic.

Sign in to view
@maxsharabayko maxsharabayko merged commit f86df39 into Haivision:master Nov 18, 2022
@maxsharabayko maxsharabayko deleted the build/disable-win-conntimeout-test branch November 18, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[build] Area: Changes in build files Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@maxsharabayko @ethouris @codecov-commenter