Refax: safety improvements #2517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gou4shi1
reviewed
Nov 8, 2022
| @@ -11019,7 +11019,10 @@ int srt::CUDT::checkNAKTimer(const steady_clock::time_point& currtime) | |||
| * not knowing what to retransmit when the only NAK sent by receiver is lost, | |||
| * all packets past last ACK are retransmitted (rexmitMethod() == SRM_FASTREXMIT). | |||
| */ | |||
| enterCS(m_RcvLossLock); | |||
There was a problem hiding this comment.
A ScopedLock would mean a nested block here ({ }), which is not a good practice.
A separate dedicated function might make sense then.
int CUDT::getRcvLossLengthLock()
{
ScopedLock lck(m_rcvLossLock);
return m_pRcvLossList->getLossLength();
}There was a problem hiding this comment.
With an extra scope {}, it can handle exceptions better.
CUDT::getRcvLossLengthLock() is a better idea.
There was a problem hiding this comment.
Another style is moving the m_rcvLossLock into m_pRcvLossList so that users don't need to care these issues.
There was a problem hiding this comment.
That makes no sense actually because the use of this function in the future buffer will be reduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_pRcvLossList->getLossLength()(affinity:CRcvQueue::worker) added a mutex lock because this container may be also modified in theCUDT::dropFromLossListthat is among others also called fromCUDT::rcvDropTooLateUpTo(affinity:CUDT::tsbpd). Of course, the list can be also modified before sending the lossreport could be done, but this will then recheck the losses anyway.