Refax: removed the synconmsg property and its handling in the groups #2509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2509 +/- ##
==========================================
+ Coverage 65.48% 66.08% +0.59%
==========================================
Files 99 99
Lines 19698 19688 -10
==========================================
+ Hits 12900 13011 +111
+ Misses 6798 6677 -121
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the handling of synconmsg property in the group. There are no predicted implementations of synchronizing the groups' transmission on the message number and this flag complicates the code. The flag itself remains, as per protocol description, although this may be deprecated in the future, as this is currently the only flag in use.